Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version parser to aiida core utils #2096

Closed
ltalirz opened this issue Oct 23, 2018 · 3 comments
Closed

add version parser to aiida core utils #2096

ltalirz opened this issue Oct 23, 2018 · 3 comments
Assignees

Comments

@ltalirz
Copy link
Member

ltalirz commented Oct 23, 2018

This piece of code to parse the aiida version will be useful for any plugin that supports both aiida 0.12 and 1.0.

https://github.com/aiida-vasp/aiida-vasp/blob/268e2a41c96d8fda229937dd3c6f828853acb503/aiida_vasp/utils/aiida_utils.py#L127-L133

I suggest to add this in aiida/utils, both in release_0.12.3 and in develop

@giovannipizzi @sphuber Do you agree?

@ltalirz ltalirz self-assigned this Oct 23, 2018
@ltalirz
Copy link
Member Author

ltalirz commented Oct 23, 2018

Ok, I think this is already sufficiently covered by aiida.get_strict_version()

@ltalirz ltalirz closed this as completed Oct 23, 2018
@ltalirz
Copy link
Member Author

ltalirz commented Oct 23, 2018

Actually, this function is missing from the release_v0.12.3 branch.
I will add it.

@sphuber
Copy link
Contributor

sphuber commented Oct 23, 2018

Fixed in release_v0.12.3 in PR #2099

@sphuber sphuber closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants