Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process interface: namespace the default process inputs store_provenance, label and description #2180

Closed
sphuber opened this issue Nov 10, 2018 · 1 comment
Closed

Process interface: namespace the default process inputs store_provenance, label and description #2180

sphuber opened this issue Nov 10, 2018 · 1 comment
Assignees
@sphuber
Labels
requires discussion
Projects
v1.0.0b1
Milestone
v1.0.0b1

Comments

@sphuber
Copy link
Contributor

sphuber commented Nov 10, 2018

The current Process class in aiida-core predefines three input ports store_provenance, label and description. This reserves these keywords and effectively prohibits a user from implementing a WorkChain or workfunction with an input of the same name. We might want to namespace these three inputs. In any case, when a user does override these inputs, we should warn or except.
@sphuber sphuber added this to the v1.0.0 milestone Nov 10, 2018
@sphuber sphuber added this to To do in Node hierarchy and link types via automation Nov 10, 2018
@sphuber sphuber moved this from To do to Stage 3 in Node hierarchy and link types Nov 11, 2018
@sphuber sphuber mentioned this issue Nov 15, 2018
Merged
@sphuber sphuber mentioned this issue Dec 3, 2018
Closed
@sphuber sphuber removed this from Stage 3 in Node hierarchy and link types Dec 6, 2018
@sphuber sphuber self-assigned this Feb 26, 2019
@sphuber sphuber modified the milestones: v1.0.0, v1.0.0b1 Feb 26, 2019
@sphuber sphuber added this to To do in v1.0.0b1 via automation Feb 26, 2019
@sphuber
Copy link
Contributor Author

sphuber commented Feb 26, 2019

This was addressed in PR #2389 the options are now namespaces in metadata

@sphuber sphuber closed this as completed Feb 26, 2019
v1.0.0b1 automation moved this from To do to Done Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
requires discussion
Projects
No open projects
v1.0.0b1
  
Done
Milestone
v1.0.0b1
Development

No branches or pull requests
1 participant
@sphuber