Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remainder of old calculation state #2381

Closed
sphuber opened this issue Jan 11, 2019 · 1 comment
Closed

Remove remainder of old calculation state #2381

sphuber opened this issue Jan 11, 2019 · 1 comment
Assignees
@sphuber
Labels
priority/critical-blocking must be resolved before next release type/refactoring
Projects
v1.0.0b1
Milestone
v1.0.0b1

Comments

@sphuber
Copy link
Contributor

sphuber commented Jan 11, 2019

The old JobCalculations used to have a "calculation state" which was stored both in a separate table as well as in the attribute with key state. The table has already been dropped, but the attribute remains. Parts of the code where the state is still used to control the logic and flow of the calculations should be removed and the state should only be used as additional information that the user can query for. Then the docs should also be updated accordingly
@sphuber sphuber added this to the v1.0.0b1 milestone Jan 11, 2019
@sphuber sphuber added this to To do in v1.0.0b1 via automation Jan 11, 2019
@sphuber sphuber moved this from To do to In progress in v1.0.0b1 Jan 11, 2019
@sphuber sphuber mentioned this issue Jan 15, 2019
Merged
@sphuber
Copy link
Contributor Author

sphuber commented Jan 17, 2019

Fixed in PR #2389

@sphuber sphuber closed this as completed Jan 17, 2019
v1.0.0b1 automation moved this from In progress to Done Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sphuber sphuber

Labels
priority/critical-blocking must be resolved before next release type/refactoring
Projects
No open projects
v1.0.0b1
  
Done
Milestone
v1.0.0b1
Development

No branches or pull requests
1 participant
@sphuber