Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of top-level dir #3730

Closed
4 tasks done
ltalirz opened this issue Jan 24, 2020 · 3 comments · Fixed by #3738
Closed
4 tasks done

cleanup of top-level dir #3730

ltalirz opened this issue Jan 24, 2020 · 3 comments · Fixed by #3738

Comments

@ltalirz
Copy link
Member

ltalirz commented Jan 24, 2020

Some ideas for reducing files at the top level

  • move conftest.py to tests
  • remove bin/runaiida (is this needed?) Move to console_scripts in setup.json
  • remove examples/ (@sphuber should these go to the docs?)
  • remove utils/plugin_tpl (ok, that's not top-level but seems outdated)
@greschd
Copy link
Member

greschd commented Jan 24, 2020

* [ ]  move `conftest.py` to `tests`

Agreed - I think this should just work.

* [ ]  remove `bin/runaiida` (is this needed?)

I think this should remain. My current workflow doesn't use it much, but it is a convenient shorthand for script shebangs.

@giovannipizzi
Copy link
Member

  • remove bin/runaiida (is this needed?)
    I think this should remain. My current workflow doesn't use it much, but it is a convenient shorthand for script shebangs.

I agree, I would keep it. But maybe one could move it somewhere else? Or add it via the console_scripts?

@sphuber
Copy link
Contributor

sphuber commented Feb 14, 2020

I actually use the #!/usr/bin/env runaiida shebang a lot, so I would be in favor of keeping it. If it is indeed possible to install this through the console_scripts entry point instead, that would be an even better solution

@sphuber sphuber added this to the v1.1.2 milestone Apr 4, 2020
@sphuber sphuber modified the milestones: v1.1.2, v1.2.0 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants