Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use general function for deleting AiiDA file repository #695

Closed
ltalirz opened this issue Sep 12, 2017 · 2 comments · Fixed by #4901
Closed

Use general function for deleting AiiDA file repository #695

ltalirz opened this issue Sep 12, 2017 · 2 comments · Fixed by #4901
Assignees
Milestone

Comments

@ltalirz
Copy link
Member

ltalirz commented Sep 12, 2017

One of the things that the profile_delete function in aiida/cmdline/commands/profile.py needs to remove is the aiida file repository.

Once we support different modes of file storage (file system/object store/...) we should call the general-purpose function here.

@ltalirz ltalirz assigned ltalirz and sphuber and unassigned ltalirz Oct 9, 2017
@giovannipizzi giovannipizzi added this to To Do in Repository redesign via automation Dec 3, 2018
@giovannipizzi giovannipizzi added this to the v2.0.0 milestone Dec 3, 2018
@sphuber sphuber removed this from the v2.0.0 milestone Feb 27, 2020
@giovannipizzi giovannipizzi added this to the v2.0.0 milestone Mar 24, 2021
@giovannipizzi
Copy link
Member

Adding back to 2.0 just to make sure the delete-profile functionality does the right thing with the new-style repository

@sphuber
Copy link
Contributor

sphuber commented May 1, 2021

Just checked that it does in fact still do the right thing, but I will take the opportunity to refactor and improve the code a bit.

Repository redesign automation moved this from To Do to Done May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants