Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Upgrade to pydantic~=2.7 #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⬆ Upgrade to pydantic~=2.7 #24

wants to merge 2 commits into from

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented May 8, 2024

Fixes #20

@mbercx mbercx requested a review from GeigerJ2 May 8, 2024 08:49
Copy link
Collaborator

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, just took it for a spin in a GitHub codespace instance as to not fuck up my local setup (like usual ahaha). Looks all good to me! I stumbled on an error where access to the config env_file wasn't updated, and took the freedom to fix it and push to your branch (see my commit). With this:

$ aiida-project init (for bash)
$ aiida-project create test
$ cda (after source ~/.bashrc)
$ aiida-project destroy test

all worked fine.

"python-dotenv~=1.0",
"typer[all]~=0.9",
"pyyaml~=6.0",
"eval_type_backport",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this dependency for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

⬆️ Update BaseSettings import and pydantic dependency to v2.6
2 participants