Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow relabelling if spin configuration changes #66

Open
bastonero opened this issue Apr 19, 2024 · 0 comments · May be fixed by #67
Open

Do not allow relabelling if spin configuration changes #66

bastonero opened this issue Apr 19, 2024 · 0 comments · May be fixed by #67

Comments

@bastonero
Copy link
Collaborator

In some rare cases, if one starts with e.g. an antiferromagnetic configuration, and after the first cycle ends up in a different spin configuration, the current the relabelling would fail. It is possible to fix it, but then we raise the question whether to continue on with the calculation, or stop it and report an exit code that the magnetic configuration is probably different from the starting one.

Example:

  1. Iteration: start with e.g. Fe0 and Fe1, having starting magnetization +1 and -1 respectively
  2. Iteration: the scf leads to Fe0 and Fe1 having 0 magnetic moments --> hp will set the label spin to 0, and this will make the relabelling to crash.

How to fix:

  • Simply catch the excpetion, either within the relabelling (maybe better?) or the self-consistent cycle.
bastonero added a commit that referenced this issue Apr 19, 2024
Fixes #66

The relabel function might not work if the spin configuration
changes and the kinds cannot be determined uniquely by
the parsed configuration from the hp.x post-processing.
For this reason, we catch the error and exit smoothly with
a new exit code if this would happen.
@bastonero bastonero linked a pull request Apr 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant