This repository has been archived by the owner on May 7, 2021. It is now read-only.
Generalize the SsspFamily
to the UpfFamily
group plugin
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
The functionality provided by the
SsspFamily
is very useful but cancurrently, by design choice, only be used for actual SSSP configurations.
The original idea of the plugin and
SsspFamily
is to not make iteasier for peopl to work with the SSSP but also make it less likely that
incorrect SSSP configurations are used.
However, there is still a common use case for UPF families that are not
strict SSSP configurations. Therefore, we generalize it to the new
plugin
UpfFamily
which represents a generic family of UPF files. TheSsspFamily
then simply is a subclass as it just imposes additionalconstraints.
The idea is that the
SsspFamily
can only be used for SSSPconfigurations and all other use cases will employ the
UpfFamily
plugin instead. Note that it will be difficult to prevent people from
using the
SsspFamily
group for non-SSSP families, but there will neverbe a way to prevent this. Instead we will simply not provide a command
line interface to create
SsspFamily
instances from anything other thanthe official resources from the Materials Cloud Archive entry.