Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ NEW: Add a sleep argument to submit_new_batch #11

Open
mbercx opened this issue Apr 17, 2023 · 0 comments · May be fixed by #20
Open

✨ NEW: Add a sleep argument to submit_new_batch #11

mbercx opened this issue Apr 17, 2023 · 0 comments · May be fixed by #20

Comments

@mbercx
Copy link
Member

mbercx commented Apr 17, 2023

Currently there is no pause between submissions in the BaseSubmissionControllersubmit_new_batch() method:

aiida-submission-controller/aiida_submission_controller/base.py

Lines 186 to 197 in fad21ad

for workchain_extras in to_submit:
# Get the inputs and the process calculation for submission
inputs, process_class = self.get_inputs_and_processclass_from_extras(
workchain_extras)
# Actually submit
res = engine.submit(process_class, **inputs)
# Add extras, and put in group
res.set_extra_many(
dict(zip(self.get_extra_unique_keys(), workchain_extras)))
self.group.add_nodes([res])
submitted[workchain_extras] = res

However, a short sleep in between can have several benefits:

  • Users can see issues with the submission and cancel the loop.
  • Having a short sleep in between submissions typically plays nicer with the AiiDA daemon workers.
t-reents added a commit to t-reents/aiida-submission-controller that referenced this issue Mar 6, 2024
@t-reents
Add optional delay between submissions
4db1dfc 
Closes aiidateam#11
@t-reents t-reents linked a pull request Mar 6, 2024 that will close this issue
Open
t-reents added a commit to t-reents/aiida-submission-controller that referenced this issue Mar 6, 2024
@t-reents
Add optional delay between submissions
c642c2c 
Closes aiidateam#11
mbercx pushed a commit to t-reents/aiida-submission-controller that referenced this issue May 7, 2024
@t-reents @mbercx
Add optional delay between submissions
5791f42 
Closes aiidateam#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add sleep argument to submit_new_batch and fix verbose t-reents/aiida-submission-controller
1 participant
@mbercx