Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leftover old-style construction of Computer instances #2007

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Sep 28, 2018

The Computer class was recently ported to the backend interface but
these few constructions were missed in the refactoring.

The Computer class was recently ported to the backend interface but
these few constructions were missed in the refactoring.
@coveralls
Copy link

coveralls commented Sep 28, 2018

Coverage Status

Coverage increased (+3.7%) to 67.827% when pulling 1cfe380 on sphuber:fix_leftover_incorrect_computer_instantiations into a2281af on aiidateam:develop.

Copy link
Contributor

@muhrin muhrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Thanks!

@sphuber sphuber merged commit 36d6aef into aiidateam:develop Sep 28, 2018
@sphuber sphuber deleted the fix_leftover_incorrect_computer_instantiations branch September 28, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants