Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with pnpm #27

Closed
eshaham opened this issue Jun 15, 2022 · 4 comments
Closed

Does not work with pnpm #27

eshaham opened this issue Jun 15, 2022 · 4 comments

Comments

@eshaham
Copy link

eshaham commented Jun 15, 2022

It seems like the patching doesn't work properly when using pnpm as the package manager.
Should be fairly easy to re-produce - take one of the samples you have (we're using mantine).
Steps to reproduce:

  • Remove node_modules folder
  • Install pnpm globally
  • Run pnpm install

I also reproduced the problem in this repo: https://github.com/eshaham/remix-esbuild-override-pnpm

@tedbyron
Copy link

tedbyron commented Jun 20, 2022

I'm also having the same error with pnpm, ReferenceError: Buffer is not defined when I run miniflare

@aiji42
Copy link
Owner

aiji42 commented Jun 20, 2022

@eshaham
In the repository you shared, the problem was resolved by either deleting the esbuild in package.json or matching the version with @remix-run/dev's (v0.14.22).

"devDependencies": {
    "@cloudflare/workers-types": "^3.10.0",
    "@esbuild-plugins/node-globals-polyfill": "^0.1.1",
    "@remix-run/dev": "^1.6.0",
    "@remix-run/eslint-config": "^1.6.0",
    "@types/react": "^17.0.45",
    "@types/react-dom": "^17.0.17",
    "esbuild": "0.14.22", // or remove
    "eslint": "^8.15.0",
    "npm-run-all": "^4.1.5",
    "remix-esbuild-override": "^3.0.4",
    "typescript": "^4.6.4",
    "wrangler": "beta"
  },

@aiji42
Copy link
Owner

aiji42 commented Jun 20, 2022

@tedbyron If you share your repository with me, I may be able to help you solve your problem.

@aiji42 aiji42 closed this as completed Jul 12, 2022
@iDVB
Copy link

iDVB commented Feb 14, 2023

@aiji42 I have remix-esbuild-override "building" ok with pnpm but our issue still persists.
Using this as a guide does not work for us.
https://mortenbarklund.com/blog/styled-components-remix/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants