Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore to aiken new project generation #200

Closed
Tracked by #198
MitchTurner opened this issue Dec 21, 2022 · 3 comments · Fixed by #209
Closed
Tracked by #198

Add .gitignore to aiken new project generation #200

MitchTurner opened this issue Dec 21, 2022 · 3 comments · Fixed by #209
Assignees
Labels
help welcomed Contributor friendly tooling Tooling and developer experience improvements
Milestone

Comments

@MitchTurner
Copy link
Contributor

What is your idea? Provide a use case.

When you run aiken new the project comes with a free .gitignore:

build
assets

aiken.lock

Why is it a good idea?

Most people don't need to include all their dependencies in the /build directory in their repo. /assets and aiken.lock are also often superfluous.

What is the current alternative and why is it not good enough?

You could add it by hand.
But I think most people are gonna want /build and /assets and aiken.lock ignored from their repo.

@KtorZ KtorZ mentioned this issue Dec 21, 2022
14 tasks
@rvcas
Copy link
Member

rvcas commented Dec 21, 2022

the aiken.lock file should not be ignored

@MitchTurner
Copy link
Contributor Author

MitchTurner commented Dec 21, 2022

@rvcas
Cool. I'm curious why you'd want to keep it. I've seen people go both ways with cargo.lock and I've never given it the time to understand why.

@rvcas
Copy link
Member

rvcas commented Dec 21, 2022

@MitchTurner I believe it's related to reproducible builds or something, I've always committed the lock file for everything so I was under the impression it was a settled matter.

@KtorZ KtorZ added this to the Basic Tooling milestone Dec 22, 2022
@KtorZ KtorZ added help welcomed Contributor friendly tooling Tooling and developer experience improvements labels Dec 22, 2022
@rvcas rvcas self-assigned this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help welcomed Contributor friendly tooling Tooling and developer experience improvements
Projects
Status: 🚀 Released
Development

Successfully merging a pull request may close this issue.

3 participants