Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not generate warnings for the presence tests in a validator module #284

Closed
Tracked by #191
matiwinnetou opened this issue Jan 17, 2023 · 0 comments
Closed
Tracked by #191
Assignees
Labels
typechecking Types and inference
Milestone

Comments

@matiwinnetou
Copy link

What Git revision are you using?

main one as of time of writing

What operating system are you using, and which version?

  • [x ] macOS

Describe what the problem is?

I added one test to my code and got the following warning:

  ⚠ While trying to make sense of your code...
  ╰─▶ I found a public definition in a validator module.
      Definitions in validator modules do not need to be public.
      
     ╭─[/Users/mati/Devel/OpenSource/aiken/examples/english_auction/validators/english_auction.ak:345:1]
 345 │ 
 346 │ test get_payment_addr_hash_test() {
     · ───
 347 │   let bytes = #[1]
     ╰────

Summary
    0 errors, 1 warning

What should be the expected behavior?

I didn't expect any warnings.

@KtorZ KtorZ changed the title Aiken warning where I didn't expect warning for tests Do not generating warnings for the presence tests in a validator module Jan 17, 2023
@KtorZ KtorZ added the typechecking Types and inference label Jan 17, 2023
@KtorZ KtorZ self-assigned this Jan 17, 2023
@KtorZ KtorZ added this to the Language PoC milestone Jan 17, 2023
@KtorZ KtorZ mentioned this issue Jan 17, 2023
27 tasks
@matiwinnetou matiwinnetou changed the title Do not generating warnings for the presence tests in a validator module Do not generate warnings for the presence tests in a validator module Jan 17, 2023
@KtorZ KtorZ closed this as completed in ce65236 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typechecking Types and inference
Projects
Status: 🚀 Released
Development

No branches or pull requests

2 participants