-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename package #12
Comments
Thanks for your input and thanks for sharing You are right in that Redux dependency is not really needed, though I've planned to include some utilities for building reducers which might depend on Redux. There's already a module with helpers for In general I like the idea of decoupling from Redux, but that means that we'd have to publish helpers as separate packages, like |
Admittedly I wasn't thinking about the saga aspect when I was first opened this issue 😄. Though it doesn't change my gut instinct. At the very least I think it would be good to remove the |
Just released |
Very cool, will try it out this weekend. |
I migrated to new package and my app seems to be working well. I think we can close this one out. Nice work! |
I think it might be good to rename this package to
typescript-fsa
orfsa-typescript
or something along those lines. This library can technically be used with any FSA compliant flux implementation, or even something else. For example I am currently using it in a cycle.js project.On top of this, the redux dependency probably isn't necessary. We could reimplement the
ReduxAction
type in this library and be fairly certain that the API won't change as FSA is a pretty concrete interface at this point in time.Also if you haven't seen it, should take a look at https://github.com/UrbanDoor/typed-fsa. Seems there are similar goals for both of these projects. Though I prefer this library's
isType
check over that other library'sisAction
check for narrowing, as there is no need to declare the payload again.Thanks for all the hard work!
The text was updated successfully, but these errors were encountered: