Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #12

Closed
farism opened this issue Feb 27, 2017 · 5 comments
Closed

Rename package #12

farism opened this issue Feb 27, 2017 · 5 comments

Comments

@farism
Copy link

farism commented Feb 27, 2017

I think it might be good to rename this package to typescript-fsa or fsa-typescript or something along those lines. This library can technically be used with any FSA compliant flux implementation, or even something else. For example I am currently using it in a cycle.js project.

On top of this, the redux dependency probably isn't necessary. We could reimplement the ReduxAction type in this library and be fairly certain that the API won't change as FSA is a pretty concrete interface at this point in time.

Also if you haven't seen it, should take a look at https://github.com/UrbanDoor/typed-fsa. Seems there are similar goals for both of these projects. Though I prefer this library's isType check over that other library's isAction check for narrowing, as there is no need to declare the payload again.

Thanks for all the hard work!

@aikoven
Copy link
Owner

aikoven commented Feb 27, 2017

Thanks for your input and thanks for sharing typed-fsa, I haven't seen it before.

You are right in that Redux dependency is not really needed, though I've planned to include some utilities for building reducers which might depend on Redux. There's already a module with helpers for redux-saga. However, this module is not imported from index.ts and redux-saga is listed as optional dependency.

In general I like the idea of decoupling from Redux, but that means that we'd have to publish helpers as separate packages, like typescript-fsa-redux-saga. Still, I guess this should be done anyway.

@farism
Copy link
Author

farism commented Feb 27, 2017

Admittedly I wasn't thinking about the saga aspect when I was first opened this issue 😄. Though it doesn't change my gut instinct.

At the very least I think it would be good to remove the redux dependency and reimplement the base Action interface. We could discuss possible options for helpers.

@aikoven
Copy link
Owner

aikoven commented Mar 3, 2017

Just released typescript-fsa@2.0.0.

@farism
Copy link
Author

farism commented Mar 3, 2017

Very cool, will try it out this weekend.

@farism
Copy link
Author

farism commented Mar 5, 2017

I migrated to new package and my app seems to be working well. I think we can close this one out. Nice work!

@farism farism closed this as completed Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants