New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.1.0 breaking change; async start() with payload is now forbidden. #24
Comments
I am truly sorry about this, payloads are meant to be allowed for I will revert and deprecate version |
Released |
@aikoven Thanks, and sorry to go off on you a bit. I misread one the tests, then inferred nonexistent intent. |
@aikoven Couldn't you have the same result by declaring the payload field of Action non mandatory ? I tried this solution (with all fields related to payload like params, etc...) and i think you lose nothing in term of the security of the typings. |
@tblaisot We'd lose the ability for the compiler to tell us if there is a payload or not, which we currently have with |
I'm going to close this now, please feel free to reopen if there's a case. |
So... I was using a real payload in async
.start()
, and now it won't even compile, which I suppose is a good thing, since it doesn't work. Clearly this is intentional; there's even a test to make sure payloads aren't allowed.Semver, please? If you're going to deliberately break stuff that works now, bump the major rev number.
Falling back to 2.0 for now. Please let me know if this (i.e., forbidding
.start()
payload) is permanent.The text was updated successfully, but these errors were encountered: