Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude non-project code from PYPI package #186

Open
rlog58 opened this issue Sep 11, 2023 · 0 comments · May be fixed by #237
Open

Exclude non-project code from PYPI package #186

rlog58 opened this issue Sep 11, 2023 · 0 comments · May be fixed by #237
Assignees
@rlog58
Labels
invalid This doesn't seem right

Comments

@rlog58
Copy link
Collaborator

rlog58 commented Sep 11, 2023

Using packages=setuptools.find_packages(exclude=['test*']), to configure directories for the PYPI package results in python packages being used from the root directory, which in our case are:

  • golem,
  • docs,
  • examples,
  • experiments.

The last ones don't look necessary in a public package. Because in such a case dependencies are littered and may be overridden by other dependencies
@rlog58 rlog58 added the invalid This doesn't seem right label Sep 11, 2023
@rlog58 rlog58 self-assigned this Nov 1, 2023
@rlog58 rlog58 linked a pull request Nov 1, 2023 that will close this issue
GOLEM-186 Golem restructure, remove redundant code from pypi distribution #237
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlog58 rlog58

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GOLEM-186 Golem restructure, remove redundant code from pypi distribution aimclub/GOLEM
1 participant
@rlog58