Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to textarea component #204

Open
mischacolley opened this issue May 4, 2020 · 4 comments
Open

Add border to textarea component #204

mischacolley opened this issue May 4, 2020 · 4 comments
Assignees

Comments

@mischacolley
Copy link
Contributor

Re https://aimementoring.slack.com/archives/GDJCPH517/p1588371533000100

@rin
Copy link
Contributor

rin commented May 4, 2020

I wanted to do something about it, but to be honest I got confused.

  1. In the design system, the text area does not have a border. It just has a light blue background.
  2. I wonder if for textarea and labeledTextarea we should maybe use the same component in Blueprint, just with a prop if it has a label or not. Because in Portal MR "My Story", we're not using the labeled textarea because there's a full paragraph above the text area explaining that we want to know the story of the applicant. (So adding a label to that textarea would feel obsolete.) But right now we have textarea and labeled textarea and they are different components and they are styled differently. (Actually, in the current Blueprint style guide textarea doesn't seem to have any styles at all? http://blueprint.aimementoring.com/#textarea )

Anyway, I'm not sure what's right here – how it is supposed to look. I guess it shouldn't be white on white background with no border, but I think we might just want to add a (themed) background-color …? cc @lulen11

@mischacolley
Copy link
Contributor Author

mischacolley commented May 5, 2020

@charliemckenzie one for your Design System review to give us an answer on .... and then maybe you wanna go through the motions of making the component update as well to take it full cycle ....

@rin
Copy link
Contributor

rin commented May 28, 2020

Hey @charliemckenzie ! Can you just let me know how the text area is supposed to look … so it's not white on white with white border anymore :) .

@charliemckenzie
Copy link

@rin Sorry I didn't get to this!
I'd go for the same as a text input, just larger text area if that makes sense :)
The one in there now is an old placeholder, as I was pulled away. But it's back on my radar now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants