-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns in Grape Editor are hard to manipulate #7
Comments
That depends on what you think the problem is. If the column is too small, you could add more padding or add a minimum height for columns: |
Thank you, it solved the issue. I think it's better to put a bigger padding by default, the 10 px value is nearly impossible to work with (I may be wrong^^) |
A padding has the problem that is may interfere too much with the design of the frontend. Is this change enough for you?
|
Understood, but it's not enough, i'm obliged to add it in .row |
If you need more space between the row and the columns, we should use the padding instead. Is it enough to increase the row padding from 10px to 20px? |
Indeed, i think it's enough, but, it still has a weird behaviour compared to adding "min-height".
|
Your screenshots always shows the same image so we can't see what you mean |
It's a .gif (animated screenshots), you just have to wait some seconds to charge :D |
OK, can you create a pull request with the necessary changes? |
Sure, can you first choose beetween the last 2 behaviours ? ( With padding or min-height ) |
Think, the min-height way would be preferrable |
Done : #8 |
Hello Aimeos, I added grapejs to my aimeos project (Laravel), and i figured that the editor in the content section (JQADM) has a small issue : After inserting the columns, it's really hard to insert text or any content inside.
Is it a general issue ?
Thank you
The text was updated successfully, but these errors were encountered: