Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] switch to TSL links #202

Closed
xerc opened this issue Jul 28, 2020 · 8 comments
Closed

[FEATURE] switch to TSL links #202

xerc opened this issue Jul 28, 2020 · 8 comments

Comments

@xerc
Copy link
Contributor

xerc commented Jul 28, 2020

https://github.com/aimeos/aimeos-core/search?q=http%3A%2F%2Fdemo.aimeos.org

@aimeos
Copy link
Owner

aimeos commented Jul 28, 2020

What does that mean?

@xerc
Copy link
Contributor Author

xerc commented Jul 28, 2020

did you see the link? you are using non TSL links; alias "HTTP"

@aimeos
Copy link
Owner

aimeos commented Aug 3, 2020

The demo.aimeos.org domain already supports HTTPS. Can you create a PR changing http to https?

@xerc
Copy link
Contributor Author

xerc commented Aug 3, 2020

for expl. CHANGE
this http://demo.aimeos.org/media/service/pickup.png
to https://demo.aimeos.org/media/service/pickup.png
WITHIN the source-code @

'image' => 'http://demo.aimeos.org/media/service/pickup.png',

.. repeat

@aimeos
Copy link
Owner

aimeos commented Aug 3, 2020

yes

@xerc
Copy link
Contributor Author

xerc commented Aug 3, 2020

btw/ there are a lot off OFFLINE links within i18n/po-files & more

@aimeos
Copy link
Owner

aimeos commented Aug 3, 2020

3122da3

Can you create a pull request so we are able to merge it?

@aimeos
Copy link
Owner

aimeos commented Aug 3, 2020

This is a dead link indeed

The page is only avilable if you log into Transifex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants