Pytorch Lighting arguments marked as Optional but needed

[TommasoBendinelli]

Hello!
I am looking at your logger internal, and here I see that the args are optional.

class _PytorchLightningLogger(LightningLoggerBase):
            def __init__(
                self,
                repo: Optional[str] = None,
                experiment: Optional[str] = None,
                train_metric_prefix: Optional[str] = "train_",
                val_metric_prefix: Optional[str] = "val_",
                test_metric_prefix: Optional[str] = "test_",
                flush_frequency: int = DEFAULT_FLUSH_FREQUENCY,
            ):

Nevertheless, if I do not fill anything inside and try to run a model, I get the following error when running model.fit

  File "/home/gem/.pyenv/versions/3.8.6/lib/python3.8/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/home/gem/.pyenv/versions/3.8.6/lib/python3.8/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '
TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

[gorarakelyan]

Hi @TommasoBendinelli ,

Can you please share what arguments you passed to the pytorch lightning logger constructor?

[TommasoBendinelli]

sure,

from aim.pytorch_lightning import AimLogger
trainer = pl.Trainer(gpus=-1, max_epochs=1000, logger=AimLogger())

[gorarakelyan]

Hm, that's weird. Are you running it from inside virtualenv/conda?

[TommasoBendinelli]

I am running the code within a virtualenv and using hydra

[gorarakelyan]

Thanks for the details. We are looking into it.

[gorarakelyan]

@TommasoBendinelli just noticed this issue remained unresponded, sorry for a really late reply.
All the loggers have been updated recently, the issue has to be fixed now. If it is not, pls reopen this issue, we will investigate. 🙏