Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_body_from_data() function arguments change #3

Closed
shanipribadi opened this issue Oct 30, 2015 · 2 comments
Closed

update_body_from_data() function arguments change #3

shanipribadi opened this issue Oct 30, 2015 · 2 comments

Comments

@shanipribadi
Copy link

Commit aio-libs/aiohttp@66a2784 adds skip_auto_header as another arguments for update_body_from_data.

aiocouchdb currently fails with:
TypeError: update_body_from_data() takes 2 positional arguments but 3 were given

the function call in https://github.com/aio-libs/aiocouchdb/blob/master/aiocouchdb/client.py#L187 and https://github.com/aio-libs/aiocouchdb/blob/master/aiocouchdb/client.py#L197 needs to be changed accordingly.

@kxepal
Copy link
Member

kxepal commented Oct 30, 2015

aiocouchdb currently not supports aiohttp >=0.18. It was an old mistake to have open range of versions for important dependencies, sorry for that! Though, this issue is fixed on master now where it strictly bounded to 0.17.3.

I'll make 0.9 in the next few hours.

@kxepal
Copy link
Member

kxepal commented Oct 31, 2015

@shanipribadi Fixed with 0.9 release.

@kxepal kxepal closed this as completed Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants