Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics #38

Open
tvoinarovskyi opened this issue May 2, 2016 · 4 comments
Open

Add metrics #38

tvoinarovskyi opened this issue May 2, 2016 · 4 comments

Comments

@tvoinarovskyi
Copy link
Member

  • We have some research to do before. Here's the list of metrics http://kafka.apache.org/documentation.html#monitoring (correct if wrong). Select ones of interest, some don't have any meaning in asyncio context (like number of select calls).
  • kafka-python has an implementation for metrics already. It would be best to reuse it to not support too much code. Some measurements are needed before thou.
@tvoinarovskyi tvoinarovskyi added this to the v0.2.0 (Sprint 2016 USA) milestone Jun 2, 2016
@tvoinarovskyi tvoinarovskyi modified the milestones: v0.2.0 (Sprint 2016 USA), 0.2.0 Nov 7, 2016
@tvoinarovskyi
Copy link
Member Author

tvoinarovskyi commented Nov 8, 2016

Metrics are still not even documented in kafka-python. I think we should wait until it becomes a stable API there before adding those...
For now I'll remove those from 0.2.0 milestone

@tvoinarovskyi tvoinarovskyi removed this from the 0.2.0 milestone Nov 8, 2016
@tvoinarovskyi
Copy link
Member Author

It's not something too complicated, but requires some time. Basically we need to take the metrics aggregators present in kafka-python and call sensors for respectful events. Like self._sensors.records_fetch_lag.record(highwater - last_offset) after each fetch to record lag samples.

@Corfucinas
Copy link

Any progress? Just noticed the consumer does not have the method .metrics()

@jigar-bhati
Copy link

Any updates on this? Having producer/consumers metrics for aiokafka seems like a super useful thing to have for debugging client side issues or investigating client vs server problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants