Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable uuid feature #103

Merged
merged 3 commits into from Jan 21, 2016
Merged

Enable uuid feature #103

merged 3 commits into from Jan 21, 2016

Conversation

hellysmile
Copy link
Member

No description provided.

@hellysmile hellysmile changed the title Enable uuid Enable uuid feature Jan 20, 2016
jettify
jettify reviewed Jan 20, 2016
View reviewed changes
tests/test_extended_types.py
@@ -25,7 +26,7 @@ def connect(self, **kwargs):
cur = yield from conn.cursor()
yield from cur.execute("DROP TABLE IF EXISTS tbl")
yield from cur.execute("""CREATE TABLE tbl (
id SERIAL,
id UUID,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be better to have separate test for UUID extension?

@jettify
Copy link
Member

jettify commented Jan 20, 2016

Looks good but I have couple questions:

  1. do we need enable uuid by default?
  2. Is uuid feature available out of box? if not what happened in case of postgres extension package is not installed?

@hellysmile
Copy link
Member Author

  1. There is by default JSON and HSTORE, why do not have UUID?
  2. UUID is built-in PostgreSQL data type, as I remember since 8.?

@jettify
Copy link
Member

jettify commented Jan 21, 2016

Looks good to me, @asvetlov any objections to merge this PR?

@ludovic-gasc
Copy link

To my experience, uuid isn't built-in: at least with postgresql 9.4 on Debian, you need to install postgresql-contrib and enable extension uuid-ossp.

@hellysmile
Copy link
Member Author

uuid-ossp is for generation UUID via PostgreSQL server.
UUID data type is not uuid-ossp

@ludovic-gasc
Copy link

@hellysmile thanks for the info.
+1 for that then.

@asvetlov
Copy link
Member

Perfect!

asvetlov added a commit that referenced this pull request Jan 21, 2016
@asvetlov
Merge pull request #103 from hellysmile/enable_uuid
aa57492 
Enable uuid feature
@asvetlov asvetlov merged commit aa57492 into aio-libs:master Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hellysmile @jettify @ludovic-gasc @asvetlov