Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlalchemy adapter trx begin allow transaction_mode #498

Merged
merged 2 commits into from Sep 4, 2018

Conversation

shanecarey17
Copy link
Contributor

Allows transaction mode to be set on SAConnection.begin() method calls

@shanecarey17 shanecarey17 reopened this Aug 22, 2018
@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #498 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   93.59%   93.67%   +0.08%     
==========================================
  Files          25       25              
  Lines        3684     3733      +49     
  Branches      195      198       +3     
==========================================
+ Hits         3448     3497      +49     
  Misses        198      198              
  Partials       38       38
Impacted Files Coverage Δ
aiopg/sa/connection.py 85.14% <100%> (+0.61%) ⬆️
tests/test_sa_transaction.py 86.64% <100%> (+2.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c761048...337057f. Read the comment docs.

@vir-mir
Copy link
Member

vir-mir commented Aug 29, 2018

LGTM - I'll salt in a couple of days.

@vir-mir vir-mir merged commit 35d6ae4 into aio-libs:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants