Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

implement pure-python fallback redis response parser #2

Closed
popravich opened this issue May 26, 2014 · 6 comments
Closed

implement pure-python fallback redis response parser #2

popravich opened this issue May 26, 2014 · 6 comments
Labels

Comments

@popravich
Copy link
Contributor

for case when hiredis is not available

@popravich popravich added this to the v0.0.2 milestone May 26, 2014
@popravich popravich self-assigned this May 26, 2014
@popravich popravich changed the title implement pure-python redis response parser implement pure-python fallback redis response parser May 26, 2014
@popravich popravich added the task label May 28, 2014
@asvetlov
Copy link
Contributor

Sounds good for me, but for you that means extra code and tests.
Do you really want to implement the feature very soon?
I guess to postpone one to the future.
At least you can make translation of hiredis events into aioredis ones and do not implement pure python parser.

@popravich popravich modified the milestones: v0.1, v0.0.2 May 30, 2014
@popravich popravich removed their assignment Jun 13, 2014
@popravich popravich removed this from the v0.1 milestone Jun 20, 2014
@popravich
Copy link
Contributor Author

Won't do. hiredis is much faster. It would sound more reasonable to improve hiredis parser.

@kernel0
Copy link
Contributor

kernel0 commented Mar 5, 2015

because hiredis package does not support windows, windows user can't use aioredis. Is there workaround?

@popravich
Copy link
Contributor Author

hmm...

@popravich
Copy link
Contributor Author

ok. I'll consider this

@kernel0
Copy link
Contributor

kernel0 commented Mar 5, 2015

thank you! 👍

Jawshua pushed a commit to Jawshua/aioredis that referenced this issue May 17, 2018
Finishing functionality for redis cluster
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants