Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Get rid of fill_free call from the create_pool #246

Closed
pfreixes opened this issue Jun 12, 2017 · 0 comments
Closed

Get rid of fill_free call from the create_pool #246

pfreixes opened this issue Jun 12, 2017 · 0 comments
Labels
resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.

Comments

@pfreixes
Copy link
Contributor

The idea is allow further pools to do not give support to the fill_free internal method, putting it hide at the current implementation and making it a none hard requirement.

Further pools can decide to do it in another ways, leaving future connections openned perhaps.

To keep backward compatibility with the current one the fill free might be called using an ensure future wrapped with an event to signal future waiters.

Thoughts?

@seandstewart seandstewart added the resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version. label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.
Projects
None yet
Development

No branches or pull requests

2 participants