Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually include LICENSE file #436

Merged
merged 1 commit into from Mar 18, 2023
Merged

Actually include LICENSE file #436

merged 1 commit into from Mar 18, 2023

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Aug 12, 2022

What do these changes do?

License file is missing from distribution. This change fixes an issue.

Are there changes in behavior for the user?

Yes. Users can read license file, packagers shouldn't add hacks to package license file.

Related issue number

No issues.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

(I've checked all checkboxes, however they are not applicable, and there is no CHANGES folder in this repository)

@jettify jettify merged commit c7215a0 into aio-libs:master Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants