Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed the pairs buffer #396

Merged
merged 6 commits into from Nov 22, 2019
Merged

Embed the pairs buffer #396

merged 6 commits into from Nov 22, 2019

Conversation

asvetlov
Copy link
Member

To amortize the memory usage of multidicts smaller than 29 elements
I expect that only very few HTTP messages have a bigger amount of headers,
the same for GET query arguments or multipart forms.

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files           5        5           
  Lines         471      471           
=======================================
  Hits          354      354           
  Misses        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 611c38c...6daa5a8. Read the comment docs.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 22, 2019
Copy link
Contributor

@iemelyanov iemelyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov asvetlov changed the title Embed pairs buffer Embed the pairs buffer Nov 22, 2019
@asvetlov asvetlov merged commit 33279b2 into master Nov 22, 2019
@asvetlov asvetlov deleted the embed-pairs-buffer branch November 22, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants