Since multidicts can be inherited they should call tp_free slot explicitly #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 5 5
Lines 471 471
=======================================
Hits 354 354
Misses 117 117Continue to review full report at Codecov.
|
iemelyanov
reviewed
Nov 24, 2019
| @@ -589,7 +589,7 @@ multidict_tp_dealloc(MultiDictObject *self) | |||
| PyObject_ClearWeakRefs((PyObject *)self); | |||
| }; | |||
| pair_list_dealloc(&self->pairs); | |||
| PyObject_GC_Del(self); | |||
| Py_TYPE(self)->tp_free((PyObject *)self); | |||
There was a problem hiding this comment.
What about adding macro #define MultiDictTpFree(ob) (Py_TYPE(ob)->tp_free((PyObject *)ob)) ?
There was a problem hiding this comment.
This macro will be used at most twice: once for MultiDict/CIMultiDict and once for their proxies.
Do we really need the macro for such a case?
The expanded version is better readable from my perspective.
iemelyanov
approved these changes
Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.