Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return class from __class_getitem__ to simplify subclassing #413

Merged
merged 7 commits into from Dec 6, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Dec 5, 2019

E.g.

class MyDict(MultiDict[str]):
    pass

URL of RTD document: https://multidict.readthedocs.io/en/fix-class_getitem/ Documentation Status

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 5, 2019
@codecov
Copy link

codecov bot commented Dec 5, 2019

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   75.81%   75.81%           
=======================================
  Files           5        5           
  Lines         488      488           
=======================================
  Hits          370      370           
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d57cd41...4fda315. Read the comment docs.

multidict/_multidict.c Outdated Show resolved Hide resolved
@asvetlov asvetlov merged commit 998ce64 into master Dec 6, 2019
@asvetlov asvetlov deleted the fix-class_getitem branch December 6, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants