Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashes in popone/popall when default is returned #450

Merged
merged 4 commits into from Dec 30, 2019
Merged

Conversation

asvetlov
Copy link
Member

The returned value was not increfed.

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 30, 2019
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #450 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   75.97%   75.97%           
=======================================
  Files           5        5           
  Lines         487      487           
=======================================
  Hits          370      370           
  Misses        117      117

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5708721...8d789a3. Read the comment docs.

@asvetlov
Copy link
Member Author

@iemelyanov thanks for the review!

@asvetlov asvetlov merged commit 8e1351b into master Dec 30, 2019
@asvetlov asvetlov deleted the fix-crashes branch December 30, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants