Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃И Fix pip cache keys interpolation #943

Merged
merged 2 commits into from Feb 3, 2024

Conversation

Jamim
Copy link
Contributor

@Jamim Jamim commented Feb 2, 2024

What do these changes do?

Fix rendering of pip cache keys.

Are there changes in behavior for the user?

No.

Related issue number

N\A

Checklist

  • I think the code is well written
  • Documentation reflects the changes

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 2, 2024
@Jamim
Copy link
Contributor Author

Jamim commented Feb 3, 2024

By the way, I'm not sure whether ${{ matrix.no-extensions }} should be part of the key.
I suppose installed packages don't vary because of building C Extensions.

Currently, due to the bug this PR aims to fix, cache keys are shared between jobs with and without C Extensions.

Wouldn't it be better to just remove ${{ matrix.no-extensions }} from the keys?

CHANGES/943.contrib.rst Outdated Show resolved Hide resolved
CHANGES/943.contrib.rst Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

webknjaz commented Feb 3, 2024

I'm not sure but it's better safe than sorry.

@webknjaz webknjaz changed the title 馃И Fix rendering of pip cache keys 馃И Fix pip cache keys interpolation Feb 3, 2024
@webknjaz webknjaz merged commit 8f58e0e into aio-libs:master Feb 3, 2024
12 checks passed
@Jamim Jamim deleted the fix/pip-cache-keys branch February 3, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants