Fix MultipleProxyMiddleware

django-daiquiri · Nov 2, 2018 · f438256 · f438256
1 parent b5e00e0
commit f438256
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/daiquiri/core/middleware.py b/daiquiri/core/middleware.py
@@ -4,6 +4,7 @@
 class MultipleProxyMiddleware(MiddlewareMixin):
     """
     see also: https://docs.djangoproject.com/en/2.1/ref/request-response/
+    (but using the left most entry)
     """
 
     FORWARDED_FOR_FIELDS = [
@@ -14,11 +15,8 @@ class MultipleProxyMiddleware(MiddlewareMixin):
 
     def process_request(self, request):
         """
-        Rewrites the proxy headers so that only the most
-        recent proxy is used.
+        Rewrites the proxy headers so that only the most recent proxy is used.
         """
         for field in self.FORWARDED_FOR_FIELDS:
             if field in request.META:
-                if ',' in request.META[field]:
-                    parts = request.META[field].split(',')
-                    request.META[field] = parts[-1].strip()
+                request.META[field] = request.META[field].split(',')[0].strip()