New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query argument in retriever.get_chat_history()
#105
Comments
Hi @shreehari-aiplanet genai-stack/genai_stack/retriever/base.py Line 42 in f15b5b3
or to remove at genai-stack/genai_stack/retriever/base.py Line 38 in f15b5b3
|
@dyaramatreya It needs to be removed wherever it is declared. Retreiver's basically getting the chat history from memory. A mediator between them is responsible for the interaction between memory and retriever to get the chat history. Hence it needs to be removed from more than 2 places. |
@shreehari-aiplanet So basically, we have to delete this retriever.get_chat_history() method definition as well as the places where it is used. Am I correct? |
No, |
Ok @shreehari-aiplanet. Can I try working on this? Can you assign this issue to me? I'll make the changes and raise the PR |
But then the query parameter passed at genai-stack/genai_stack/stack/mediator.py Line 72 in f15b5b3
|
yes |
Thanks. Can you please assing this issue to me? I'll raise the PR in few hours |
@shreehari-aiplanet Please have a look at the PR raised above and suggest if it's good or any changes are needed. |
Description
Query arguement in
retriever.get_chat_history()
seems a bit ambiguous. Hence it can be removed.The text was updated successfully, but these errors were encountered: