Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the first model generator #19

Closed
3 tasks done
raar1 opened this issue Oct 27, 2022 · 0 comments · Fixed by #27
Closed
3 tasks done

Create the first model generator #19

raar1 opened this issue Oct 27, 2022 · 0 comments · Fixed by #27
Assignees
Labels
good first issue Good for newcomers

Comments

@raar1
Copy link
Contributor

raar1 commented Oct 27, 2022

For this issue we will use the transformer retention time model generating code already available in the package here

  • Add a modelgen directory to the repo (that will be accessible in the python package as aiproteomics.modelgen) to put any new model generator code in
  • Adapt the code so that it outputs the model in .onnx format (allow optionally still to output the model as a keras model as it currently does)
  • Make the file optionally also runnable from the commandline (using the if __name__ == "__main__": approach). When run from the commandline, it should only output in ONNX format
@raar1 raar1 added this to the Basic prototype milestone Oct 27, 2022
@DaniBodor DaniBodor added the good first issue Good for newcomers label Oct 28, 2022
@DaniBodor DaniBodor self-assigned this Nov 1, 2022
@DaniBodor DaniBodor linked a pull request Nov 1, 2022 that will close this issue
@raar1 raar1 moved this from To do to In progress in Pipeline redesign sprint 1 Nov 1, 2022
@DaniBodor DaniBodor moved this from In progress to Ready for review in Pipeline redesign sprint 1 Nov 4, 2022
Pipeline redesign sprint 1 automation moved this from Ready for review to Done Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

2 participants