Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pubsub]: Node ID private key as parameter. #55

Open
2 tasks
akru opened this issue May 1, 2020 · 1 comment
Open
2 tasks

[pubsub]: Node ID private key as parameter. #55

akru opened this issue May 1, 2020 · 1 comment
Labels
bounty-s enhancement New feature or request good first issue Good for newcomers

Comments

@akru
Copy link
Member

akru commented May 1, 2020

Motivation

According to #46 is better to dedicate node identity and store it into a file for long term usage.

Steps

  • Add into identity module function to save/load peer private key from file.
  • Move peer identity into Gossipsub::new() function parameter.
@akru akru added enhancement New feature or request good first issue Good for newcomers labels May 1, 2020
@akru akru added the bounty-s label May 18, 2020
@akru akru modified the milestones: v0.19.0, v0.20.0 Aug 1, 2020
@khssnv khssnv mentioned this issue Aug 15, 2020
Merged
2 tasks
@ensrationis ensrationis removed this from the v0.20.0 milestone Dec 16, 2020
@Vourhey
Copy link
Member

Vourhey commented Oct 11, 2022

Is it still relevant? @akru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty-s enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Vourhey @akru @ensrationis