Transaction support for restoring associations #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add has many associations functionality
|
Hope here will be a full test coverage. @lyfeyaj if you have a time for pairing, we can try to write some code together to get this done and push to the master. |
batter
force-pushed
the
master
branch
2 times, most recently
from
dd4280e
to
a683be8
Compare
|
Is this the preferred method for taking care of has_manies? in my code, I am storing the other papertrail record ids in a metadata field. What's the advantage of using another table? Does that hurt speed at all? I bet it would be easier to migrate though. |
|
I submitted a PR for fixing the merge conflicts: lyfeyaj#2 |
|
@lyfeyaj why is the transaction_id being stored on the module? (PaperTrail.transaction_id) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is mostly a re-implementation of the work done by @tderks and @cambridgemike with some bug fix. I didn't add tests for this pull request. Anyway, I think this solution for has-many association is ready and are already in our company's production mode. And the reason I open this pull request here is want to welcome anybody to help to test it to find if there are still some bugs and if possible add tests for it.