New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for ruby <= 2.1 #871
Conversation
0d63cea
to
bf66949
Compare
A few questions:
Not against it but it feels like just yesterday we dropped support for Ruby18 😄 |
Thanks Ben, good questions.
No.
The primary motivation is to test against the latest version of
Version 6.0.0.
Yeah, it was only four months ago, in PT 5.0.0, on 2016-05-02. I wish rubygems.org gave us statistics about what versions of ruby our users are using. They could easily collect those data. |
It looks like we can do just that. Closed by #872 Looks like we can postpone dropping 1.9.3 for now. |
CI has failed again (in e.g. #917) because yet another dependency has dropped support for ruby 1.9.3. This time it's nokogiri, one of the most important gems in the ecosystem. I think it's time for us to follow suit on |
bf66949
to
956fc17
Compare
6053dfa
to
178d492
Compare
This PR also drops support for ruby 2.0.0, which reached EOL about 10 months ago. Again, people who cannot upgrade their ruby may use old versions of PT. |
@batter any concerns about this? I know compatibility is important to you, but it is becoming hard to maintain, as the rest of the ruby ecosystem drops EOL rubies. |
@jaredbeck - No, this seems reasonable to me since the current release of Rails requires Ruby 2.2+. Also, since there is little to no work necessary to upgrade from 2.0 to 2.x, I think it reduces concern of complexity required for those who desire to upgrade. Historically I remember being stuck working on apps that were stuck on Ruby 1.8 and it was a big pain to upgrade to 1.9 and successively 2.x but that doesn't seem to be the case with modern versions of ruby, so this seems reasonable to me. |
Yeah, funny how the 1.8 - 1.9 upgrade was much worse than 1.9 - 2.0. And, I agree, the 2s (2.0, 2.1) have been very easy upgrades indeed. A sign of the maturity of the interpreter, I guess. |
According to the 2016 Rails Hosting Survey, usage of ruby 1.9.3 has dropped to around 10%, with much of this drop occuring in 2016.
The 2016 survey had 1,417 respondents.
IMO it is acceptable for development of a new major version of to continue, while the 10% of the community using 1.9.3 continues to use the previous version.
Other major gems which have dropped 1.9.3 support, in no particular order: