Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ruby <= 2.1 #871

Merged
merged 1 commit into from Jan 11, 2017
Merged

Drop support for ruby <= 2.1 #871

merged 1 commit into from Jan 11, 2017

Conversation

jaredbeck
Copy link
Member

@jaredbeck jaredbeck commented Sep 29, 2016

According to the 2016 Rails Hosting Survey, usage of ruby 1.9.3 has dropped to around 10%, with much of this drop occuring in 2016.

Usage of 1.9.3 dropped by 16% [since the 2015 survey] and adoption of Ruby 2.2 and 2.3 jumped up to 27% each.

The 2016 survey had 1,417 respondents.

IMO it is acceptable for development of a new major version of to continue, while the 10% of the community using 1.9.3 continues to use the previous version.

Other major gems which have dropped 1.9.3 support, in no particular order:

gem ruby
devise >= 2.1.0
rubocop >= 2.0.0
rails >= 2.2.2
capistrano > 2.0

@jaredbeck jaredbeck force-pushed the drop_ruby_1.9.3 branch 2 times, most recently from 0d63cea to bf66949 Compare September 29, 2016 04:17
@batter
Copy link
Collaborator

batter commented Sep 29, 2016

A few questions:

  1. Is there anything that Ruby19 is missing that makes it incompatible with the current codebase? Is this mostly for the purpose of maintaining compatibility with Rubocop?
  2. What version of PaperTrail are you targeting for this?

Not against it but it feels like just yesterday we dropped support for Ruby18 😄

@jaredbeck
Copy link
Member Author

Thanks Ben, good questions.

  1. Is there anything that Ruby19 is missing that makes it incompatible with the current codebase?

No.

Is this mostly for the purpose of maintaining compatibility with Rubocop?

The primary motivation is to test against the latest version of pg, which we are not currently doing (see #870). Do you think we could add some conditional logic to our gemspec so that we could test against different versions of pg depending on which ruby version we are testing?

  1. What version of PaperTrail are you targeting for this?

Version 6.0.0.

Not against it but it feels like just yesterday we dropped support for Ruby18 😄

Yeah, it was only four months ago, in PT 5.0.0, on 2016-05-02.

I wish rubygems.org gave us statistics about what versions of ruby our users are using. They could easily collect those data.

@jaredbeck
Copy link
Member Author

The primary motivation is to test against the latest version of pg, which we are not currently doing (see #870). Do you think we could add some conditional logic to our gemspec so that we could test against different versions of pg depending on which ruby version we are testing?

It looks like we can do just that.

Closed by #872

Looks like we can postpone dropping 1.9.3 for now.

@jaredbeck jaredbeck closed this Oct 1, 2016
@jaredbeck jaredbeck deleted the drop_ruby_1.9.3 branch October 1, 2016 04:31
@jaredbeck jaredbeck restored the drop_ruby_1.9.3 branch December 30, 2016 16:34
@jaredbeck jaredbeck reopened this Dec 30, 2016
@jaredbeck
Copy link
Member Author

jaredbeck commented Dec 30, 2016

CI has failed again (in e.g. #917) because yet another dependency has dropped support for ruby 1.9.3. This time it's nokogiri, one of the most important gems in the ecosystem. I think it's time for us to follow suit on master. People who still need ruby 1.9.3 can use older versions of PT.

@jaredbeck
Copy link
Member Author

This PR also drops support for ruby 2.0.0, which reached EOL about 10 months ago. Again, people who cannot upgrade their ruby may use old versions of PT.

@jaredbeck jaredbeck changed the title Drop support for ruby 1.9.3 Drop support for ruby 1.9.3 and 2.0 Dec 30, 2016
@jaredbeck jaredbeck changed the title Drop support for ruby 1.9.3 and 2.0 Drop support for ruby <= 2.1 Dec 30, 2016
@jaredbeck
Copy link
Member Author

@batter any concerns about this? I know compatibility is important to you, but it is becoming hard to maintain, as the rest of the ruby ecosystem drops EOL rubies.

@batter
Copy link
Collaborator

batter commented Jan 10, 2017

@jaredbeck - No, this seems reasonable to me since the current release of Rails requires Ruby 2.2+. Also, since there is little to no work necessary to upgrade from 2.0 to 2.x, I think it reduces concern of complexity required for those who desire to upgrade.

Historically I remember being stuck working on apps that were stuck on Ruby 1.8 and it was a big pain to upgrade to 1.9 and successively 2.x but that doesn't seem to be the case with modern versions of ruby, so this seems reasonable to me.

@jaredbeck jaredbeck merged commit 1f95333 into master Jan 11, 2017
@jaredbeck jaredbeck deleted the drop_ruby_1.9.3 branch January 11, 2017 04:51
@jaredbeck
Copy link
Member Author

Historically I remember being stuck working on apps that were stuck on Ruby 1.8 and it was a big pain to upgrade to 1.9 and successively 2.x but that doesn't seem to be the case with modern versions of ruby, so this seems reasonable to me.

Yeah, funny how the 1.8 - 1.9 upgrade was much worse than 1.9 - 2.0. And, I agree, the 2s (2.0, 2.1) have been very easy upgrades indeed. A sign of the maturity of the interpreter, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants