Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

characters to indicate removal immediately before change or addition #43

Closed
gfixler opened this issue Mar 7, 2013 · 2 comments
Closed

Comments

@gfixler
Copy link

gfixler commented Mar 7, 2013

I propose these signs for wherever removal precedes addition or change:

±

The former could be yellow (green + red), the latter... cyan? These symbols could default to + and ~ for users who can't display the unicode versions, and maybe be allowed to show through a global var.

@airblade
Copy link
Owner

airblade commented Mar 8, 2013

This would complicate the code because it would have to track what's happening on two lines at once, instead of just line by line. Also, as you point out, it's not obvious what colours they should have.

It's an interesting idea but on balance I don't feel it's worth it.

In terms of customisation, I just pushed some changes which (should!) make it easier to change the colours. The only thing you can't customise yet is the signs' symbols but I'll add that if there's demand – but not in a way which changes the meaning of the signs.

@airblade airblade closed this as completed Mar 8, 2013
@gfixler
Copy link
Author

gfixler commented Mar 10, 2013

I just realized you're already showing characters for both anyway. I didn't realize this, and I cede your points. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants