Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on Android M new permission model #59

Merged
merged 2 commits into from Sep 3, 2015

Conversation

felipecsl
Copy link
Contributor

Native Google Maps needs WRITE_EXTERNAL_STORAGE permission on Android M, so we should check for that as well before assuming that it is supported.
This prevents AirMapView from crashing on M.

@petzel @nwadams

@felipecsl
Copy link
Contributor Author

ugh Travis doesn't support android 23 yet...

@rafaeltoledo
Copy link

Update your .travis.yml and it should work :)

@felipecsl
Copy link
Contributor Author

oh sweet. for some reason I assumed travis was not gonna work with api 23. all clear now. thanks Rafael!

@amoljain
Copy link
Collaborator

amoljain commented Sep 3, 2015

lgtm.

felipecsl added a commit that referenced this pull request Sep 3, 2015
Prevent crash on Android M new permission model
@felipecsl felipecsl merged commit d470ef6 into master Sep 3, 2015
@felipecsl felipecsl deleted the feature/marshmallow-permissions branch January 19, 2017 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants