Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lona Studio] Pressing "Enter" should open a project on welcome screen #325

Closed
dabbott opened this issue Mar 5, 2019 · 1 comment
Closed

[Lona Studio] Pressing "Enter" should open a project on welcome screen #325

dabbott opened this issue Mar 5, 2019 · 1 comment
Labels
enhancement good first issue help wanted

Comments

@dabbott
Copy link
Member

dabbott commented Mar 5, 2019

Summary

Currently the welcome screen supports keyboard navigation through the list of recently opened projects, but pressing the "Enter" key doesn't open a project.

screen_shot_2019-03-05_at_9_09_01_am

We're copying the Xcode welcome window's behavior here: we want double-click to open a project (which it currently does) and "Enter" to open a project, but we don't want single-click to open a project.

Implementation

The project list component is in LonaStudio/Workspace/RecentProjectsList.swift. I think overriding the keyDown method and handling the return key (NSCarriageReturnCharacter) will be simplest, but I'm open to anything that works.
@dabbott
Copy link
Member Author

dabbott commented Mar 5, 2019

Tentatively for @klymenkoo

@vldmrkl vldmrkl mentioned this issue Mar 7, 2019
Merged
@dabbott dabbott closed this as completed in 40bdddc Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dabbott