Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opacity support to LS and compiler #254

Merged
merged 2 commits into from Nov 14, 2018
Merged

Add opacity support to LS and compiler #254

merged 2 commits into from Nov 14, 2018

Conversation

dabbott
Copy link
Member

@dabbott dabbott commented Nov 14, 2018

What

Support generating components with opacity.

A few quirks/limitations:

  • Opacity should be between 0 and 1. However, the LS number picker doesn't work very well with decimals at the moment. First type the number, e.g. "3", then type the "." in front of it
  • NSBox doesn't support rendering with alphaValue on macOS, and alphaValue doesn't affect subviews. We can work around this but it'll be more effort. Consider MultipliedAlphaProviding and MultipliedAlphaConsuming protocols.

Testing Plan

  • Tested this change locally
  • Checked that existing features work

@lonabot
Copy link

lonabot commented Nov 14, 2018

1 Warning
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger

@dabbott dabbott merged commit 9016dde into master Nov 14, 2018
@dabbott dabbott deleted the opacity branch November 14, 2018 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants