Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #325: Pressing "Return" key opens the selected project #328

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@klymenkoo
Copy link
Contributor

commented Mar 7, 2019

What

This PR contains fix for #325: it adds support for opening selected project from welcome screen when "Enter" was pressed.

mar-06-2019 21-01-59

In order to implement this feature, I overrode keyDown function inside the extension of RecentProjectsTableView, where I basically check if the keyCode of the pressed code is equalled to carriage return key code (36).

cc: @dabbott, @ryngonzalez

@ryngonzalez
Copy link
Collaborator

left a comment

nice!

@dabbott

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

Great job, looks good! Later today or tomorrow I'll post some more issues if you're interested in picking up another.

@dabbott dabbott merged commit 40bdddc into airbnb:master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dabbott

This comment has been minimized.

Copy link
Collaborator

commented Mar 7, 2019

Oh! I just realized (after merging) that this will crash if no rows are selected, since tableView.selected is -1 if there's no selection. I just made a quick fix and added tableView.selectedRow >= 0 to the condition.

@klymenkoo klymenkoo deleted the klymenkoo:feature/enter-project branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.