Fix #325: Pressing "Return" key opens the selected project #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job, looks good! Later today or tomorrow I'll post some more issues if you're interested in picking up another. |
|
Oh! I just realized (after merging) that this will crash if no rows are selected, since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR contains fix for #325: it adds support for opening selected project from welcome screen when "Enter" was pressed.
In order to implement this feature, I overrode
keyDownfunction inside the extension ofRecentProjectsTableView, where I basically check if the keyCode of the pressed code is equalled to carriage return key code (36).cc: @dabbott, @ryngonzalez