Hide/show bottom panel #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldmrkl
commented
Apr 11, 2019
|
I think we want to increase the minimum thickness of the bottom pane so that it can't be in that weird state where it has 0 height but it's not "collapsed": https://github.com/airbnb/Lona/blob/31e6ffdc66703efd2198cd84688904cc02daa8ce/studio/LonaStudio/Workspace/ComponentEditorViewController.swift#L215 I'm not sure what the best value would be... maybe try 200? Or play around with it and see what seems like a good default |
|
@dabbott 200 worked perfectly 👍 |
|
I've implemented your suggestions, and it seems to work fine now 🙌 |
dabbott
approved these changes
Apr 12, 2019
|
@dabbott I believe so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to share my progress on #356. I've tried to implement the suggested changes from the issue description. This is what I have so far:
If the bottom panel is in its initial state (the app has been just started, and the user selected component), the hide/show doesn't work:
If the user resizes the bottom panel, the hide/show button works fine:
