Add new keep rule for MvRxViewModelFactory without JvmStatic and initialState #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#169 Added a new
initialState
method and ability to not use@JvmStatic
all of these need keep rules.Closes #176
** Note: Kotlin 1.3+ requires this keep rule as well:
keep class kotlin.reflect.jvm.internal.impl.serialization.deserialization.builtins.BuiltInsLoaderImpl
Per the discussion in #138, this is not a project specific rule, so not including it in the proguard file, but updated wiki to suggest it.
Tested on sample app.
Created #182 to prevent this from the future. Would be a great first task if anyone from the community wants to jump on it :)
@gpeal @rossbacher