Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow functions in state #250

Merged
merged 1 commit into from Jun 25, 2019
Merged

Conversation

elihart
Copy link
Contributor

@elihart elihart commented Jun 24, 2019

I noticed someone in our app adding a lambda to state, which clearly doesn't belong, but we didn't have a check to prevent it. This seems like a good place to check for it.

@elihart elihart requested review from gpeal and BenSchwab June 24, 2019 22:52
Copy link
Collaborator

@gpeal gpeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@elihart elihart merged commit 871b3c9 into master Jun 25, 2019
@elihart elihart deleted the eli-no_function_in_state_check branch June 25, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants