Stop publishing separate debug and release artifacts for the "showakse" artifact on maven #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinaygaba
commented
Dec 20, 2022
| @@ -14,13 +14,6 @@ android { | |||
| testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" | |||
| consumerProguardFiles "consumer-rules.pro" | |||
| } | |||
|
|
|||
| buildTypes { | |||
There was a problem hiding this comment.
I'm not 100% sure that this is what was causing the issue so if you have any other ideas, I'm open to them!
|
Okay I've found the root cause. It seems like bumping up the version of the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
Showkase was publishing separate
debugandreleaseartifacts to maven and this was causing weirdness when consumers had custom build types that weren'tdebugandrelease. Moreover, this wasn't intended to be the case in the first place so I'm attempting to fix this for the future releases.@airbnb/showkase-maintainers