Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting More Types / Fixing Bugs/ Etc #2

Open
nwparker opened this issue May 7, 2018 · 0 comments · May be fixed by #3
Open

Supporting More Types / Fixing Bugs/ Etc #2

nwparker opened this issue May 7, 2018 · 0 comments · May be fixed by #3

Comments

@nwparker
Copy link
Collaborator

nwparker commented May 7, 2018

Hey @liyintang or @jingweilu1974,

Can you please reach out to me? I have done an entire re-write of the code here, but took inspiration from your code.
The version I have fixes a few bugs, supports all Thrift types & recursive structures. It also adds the functionality to convert both ways along with complete unit testing.

It'd be easier to chat offline and figure things out. If things work, I can contribute here. Otherwise I'll create a new repo. Please let me know!
@nwparker nwparker linked a pull request Sep 10, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nwparker/conv v2 airbnb/airbnb-spark-thrift
1 participant
@nwparker