Skip to content

Commit

Permalink
Formatting change_on column in list views
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Dec 11, 2015
1 parent b628713 commit 1fe1549
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
3 changes: 3 additions & 0 deletions panoramix/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ def created_by_fk(cls):
def changed_by_fk(cls):
return Column(Integer, ForeignKey('ab_user.id'),
default=cls.get_user_id, onupdate=cls.get_user_id, nullable=True)
@property
def changed_on_(cls):
return utils.datetime_f(cls.changed_on)


class Slice(Model, AuditMixinNullable):
Expand Down
14 changes: 12 additions & 2 deletions panoramix/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import hashlib
from sqlalchemy.types import TypeDecorator, TEXT
import json
from flask import g, request
from flask import g, request, Markup
import parsedatetime
import functools
from panoramix import db
Expand Down Expand Up @@ -200,5 +200,15 @@ def wrapper(*args, **kwargs):
db.session.commit()

return f(*args, **kwargs)

return wrapper


def datetime_f(dttm):
if dttm:
dttm = dttm.isoformat()
now_iso = datetime.now().isoformat()
if now_iso[:10] == dttm[:10]:
dttm = dttm[11:]
elif now_iso[:4] == dttm[:4]:
dttm = dttm[5:]
return Markup("<nobr>{}</nobr>".format(dttm))
8 changes: 4 additions & 4 deletions panoramix/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class MetricInlineView(CompactCRUDMixin, PanoramixModelView):

class DatabaseView(PanoramixModelView, DeleteMixin):
datamodel = SQLAInterface(models.Database)
list_columns = ['database_name', 'created_by', 'changed_on']
list_columns = ['database_name', 'created_by', 'changed_on_']
add_columns = ['database_name', 'sqlalchemy_uri']
search_exclude_columns = ('password',)
edit_columns = add_columns
Expand Down Expand Up @@ -137,7 +137,7 @@ def pre_update(self, db):

class TableView(PanoramixModelView, DeleteMixin):
datamodel = SQLAInterface(models.SqlaTable)
list_columns = ['table_link', 'database', 'changed_by', 'changed_on']
list_columns = ['table_link', 'database', 'changed_by', 'changed_on_']
add_columns = ['table_name', 'database', 'default_endpoint', 'offset']
edit_columns = [
'table_name', 'database', 'main_dttm_col', 'default_endpoint',
Expand Down Expand Up @@ -194,7 +194,7 @@ class SliceModelView(PanoramixModelView, DeleteMixin):
can_add = False
list_columns = [
'slice_link', 'viz_type', 'datasource_type',
'datasource', 'created_by', 'changed_on']
'datasource', 'created_by', 'changed_on_']
edit_columns = [
'slice_name', 'viz_type', 'druid_datasource',
'table', 'dashboards', 'params']
Expand All @@ -211,7 +211,7 @@ class SliceModelView(PanoramixModelView, DeleteMixin):

class DashboardModelView(PanoramixModelView, DeleteMixin):
datamodel = SQLAInterface(models.Dashboard)
list_columns = ['dashboard_link', 'created_by', 'changed_by', 'changed_on']
list_columns = ['dashboard_link', 'created_by', 'changed_by', 'changed_on_']
edit_columns = [
'dashboard_title', 'slug', 'slices', 'position_json', 'css']
add_columns = edit_columns
Expand Down

0 comments on commit 1fe1549

Please sign in to comment.