Add week ending and week start to grain #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -285,6 +285,10 @@ def grains(self): | |||
| Grain('Time Column', '{col}'), | |||
| Grain('week', "date_trunc('week', CAST({col} AS DATE))"), | |||
| Grain('month', "date_trunc('month', CAST({col} AS DATE))"), | |||
| Grain("week_ending", "date_add('day', 5, " | |||
| "date_trunc('week', date_add('day', 1, CAST({col} AS DATE))))"), | |||
| Grain("week_start", "date_add('day', -1, " | |||
There was a problem hiding this comment.
the first argument shows as the label in the dropdown, week_start_monday week_ending_sunday would be more clear.
There was a problem hiding this comment.
@mistercrunch Makes sense. Fixed!
mistercrunch
added a commit
that referenced
this pull request
Mar 21, 2016
Add week ending and week start to grain
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch Adding two new time grains for Presto
Both grains use Sunday to Saturday as definition of week.